Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jetty 11 #186

Merged
merged 18 commits into from
Nov 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ language: groovy
matrix:
include:
- jdk: openjdk11
env: TEST_ALL_CONTAINERS="['tomcat10']" GRADLE_VERSION="5.6.4"
env: TEST_ALL_CONTAINERS="['tomcat10','jetty11']" GRADLE_VERSION="5.6.4"
- jdk: openjdk15
env: TEST_ALL_CONTAINERS="['tomcat10']" GRADLE_VERSION="6.6.1"
env: TEST_ALL_CONTAINERS="['tomcat10','jetty11']" GRADLE_VERSION="6.6.1"
- jdk: openjdk11
env: TEST_ALL_CONTAINERS="['tomcat10']" GRADLE_VERSION="6.6.1"
env: TEST_ALL_CONTAINERS="['tomcat10','jetty11']" GRADLE_VERSION="6.6.1"
before_cache:
- rm -f $HOME/.gradle/caches/modules-2/modules-2.lock
cache:
Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ developerName = Andrey Hihlovskiy
license = MIT
group = org.gretty
version = 4.0.0-SNAPSHOT
jetty10_version = 10.0.0.alpha2
jetty10_servlet_api_version = 5.0.0-M1
jetty11_version = 11.0.0.beta3
jetty11_servlet_api_version = 5.0.0
tomcat10_version = 10.0.0-M9
tomcat10_servlet_api_version = 5.0.0-M1
asm_version = 9.0
Expand Down
9 changes: 4 additions & 5 deletions integrationTests/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,15 @@ include 'helloGrettyOverlay'
// Jersey 3.0.0-M1 still depends on javax.servlet internally
// include 'helloJersey'
include 'extraResourceBases'
include 'filterWebApp'
include 'filterWebapp'
include 'testAnnotations'
include 'testAnnotationsOverlay'
include 'testDependency'
include 'testDuplicatingResources'
include 'testInitParameter'
// FIXME Jetty 10 servlet container is not implemented yet (#162)
// include 'testJettyContextConfig'
// include 'testJettyRandomPorts'
// include 'testJettyServerConfig'
include 'testJettyContextConfig'
include 'testJettyRandomPorts'
include 'testJettyServerConfig'
include 'testTomcatContextConfig'
include 'testTomcatRandomPorts'
include 'testTomcatServerConfig'
Expand Down
3 changes: 1 addition & 2 deletions integrationTests/testJettyContextConfig/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ dependencies {
}

defineIntegrationTest()
// FIXME (#162)
// testAll.dependsOn defineIntegrationTestAllContainers(['jetty10'])
testAll.dependsOn defineIntegrationTestAllContainers(['jetty11'])
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?xml version="1.0"?>
<!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "https://www.eclipse.org/jetty/configure_10_0.dtd">
<Configure class="org.eclipse.jetty.webapp.WebAppContext">
<Set name="contextPath">/abc</Set>
</Configure>
3 changes: 1 addition & 2 deletions integrationTests/testJettyRandomPorts/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@ gretty {
}

defineIntegrationTest()
// FIXME (#162)
// testAll.dependsOn defineIntegrationTestAllContainers(['jetty10'])
testAll.dependsOn defineIntegrationTestAllContainers(['jetty11'])
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?xml version="1.0"?>
<!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "https://www.eclipse.org/jetty/configure_10_0.dtd">
<Configure class="org.eclipse.jetty.webapp.WebAppContext">
<Set name="contextPath">/abc</Set>
</Configure>
3 changes: 1 addition & 2 deletions integrationTests/testJettyServerConfig/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ dependencies {
}

defineIntegrationTest()
// FIXME (#162)
// testAll.dependsOn defineIntegrationTestAllContainers([''jetty10'])
testAll.dependsOn defineIntegrationTestAllContainers(['jetty11'])
1 change: 1 addition & 0 deletions integrationTests/testJettyServerConfig/jetty/jetty.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?xml version="1.0"?>
<!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "https://www.eclipse.org/jetty/configure_10_0.dtd">
<Configure id="Server" class="org.eclipse.jetty.server.Server">
<Get name="ThreadPool">
<Set name="minThreads">10</Set>
Expand Down
4 changes: 2 additions & 2 deletions libs/gretty-core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ dependencies {
tasks.processResources {
def props = [
grettyVersion: project.version,
jetty10Version: project.jetty10_version,
jetty10ServletApiVersion: project.jetty10_servlet_api_version,
jetty11Version: project.jetty11_version,
jetty11ServletApiVersion: project.jetty11_servlet_api_version,
tomcat10Version: project.tomcat10_version,
tomcat10ServletApiVersion: project.tomcat10_servlet_api_version,
springBootVersion: project.springBootVersion,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
grettyVersion=@grettyVersion@
jetty10Version=@jetty10Version@
jetty10ServletApiVersion=@jetty10ServletApiVersion@
jetty11Version=@jetty11Version@
jetty11ServletApiVersion=@jetty11ServletApiVersion@
tomcat10Version=@tomcat10Version@
tomcat10ServletApiVersion=@tomcat10ServletApiVersion@
springBootVersion=@springBootVersion@
Expand Down
23 changes: 23 additions & 0 deletions libs/gretty-runner-jetty11/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
apply from: rootProject.file('common.gradle')

configurations {
compile {
exclude group: 'org.eclipse.jetty.orbit', module: 'javax.servlet'
}
}

dependencies {
compile project(':libs:gretty-runner-jetty')
compile "jakarta.servlet:jakarta.servlet-api:$jetty11_servlet_api_version"
compile "org.eclipse.jetty:jetty-server:$jetty11_version"
compile "org.eclipse.jetty:jetty-servlet:$jetty11_version"
compile "org.eclipse.jetty:jetty-webapp:$jetty11_version"
compile "org.eclipse.jetty:jetty-security:$jetty11_version"
compile "org.eclipse.jetty:apache-jsp:$jetty11_version"
compile "org.eclipse.jetty:jetty-annotations:$jetty11_version"
compile "org.eclipse.jetty:jetty-plus:$jetty11_version"
compile "org.eclipse.jetty.websocket:websocket-jakarta-server:$jetty11_version"
compile "org.eclipse.jetty.websocket:websocket-jetty-server:$jetty11_version"
compile "org.ow2.asm:asm:$asm_version"
compile "org.ow2.asm:asm-commons:$asm_version"
}
Loading