Fix handling of httpsIdleTimeout in Tomcat (#144)

Calling toString() is mandatory, otherwise the call does not match the method signature of setProperty(String, String). This is now analog to the treatment of httpIdleTimeout, which already stringifies the property value.
gretty-gradle-plugin · May 8, 2020 · 9e21f1d · 9e21f1d
1 parent baf12ad
commit 9e21f1d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/integrationTests/helloGretty/build.gradle b/integrationTests/helloGretty/build.gradle
@@ -13,6 +13,7 @@ gretty {
   // Possible servletContainer values are 'jetty7', 'jetty8', 'jetty9', 'tomcat85', 'tomcat9'. Default is 'jetty9'.
   // servletContainer = 'tomcat8'
   // httpsEnabled = true
+  httpIdleTimeout = 424242
 }
 
 war {

diff --git a/integrationTests/helloGrettySecure/build.gradle b/integrationTests/helloGrettySecure/build.gradle
@@ -12,6 +12,7 @@ dependencies {
 gretty {
   httpEnabled = false
   httpsEnabled = true
+  httpsIdleTimeout = 424242
   // Possible servletContainer values are 'jetty7', 'jetty8', 'jetty9', 'tomcat85', 'tomcat9'. Default is 'jetty9'.
   servletContainer = 'jetty9'
   realm 'auth'

diff --git a/libs/gretty-runner-tomcat/src/main/groovy/org/akhikhl/gretty/TomcatServerConfigurer.groovy b/libs/gretty-runner-tomcat/src/main/groovy/org/akhikhl/gretty/TomcatServerConfigurer.groovy
@@ -189,7 +189,7 @@ class TomcatServerConfigurer {
         sslConfig.truststorePassword = params.sslTrustStorePassword
 
       if(params.httpsIdleTimeout)
-        httpsConn.setProperty('keepAliveTimeout', params.httpsIdleTimeout)
+        httpsConn.setProperty('keepAliveTimeout', params.httpsIdleTimeout.toString())
 
       httpsConn.setProperty('maxPostSize', '0')  // unlimited