Skip to content

Commit

Permalink
Fix classloader isolation for Gretty runners
Browse files Browse the repository at this point in the history
  • Loading branch information
boris-petrov committed Nov 18, 2019
1 parent f35a189 commit 291fd59
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ class JettyConfigurerImpl implements JettyConfigurer {
if (webappParams.webXml != null) context.setDescriptor(webappParams.webXml);
FilteringClassLoader classLoader = new FilteringClassLoader(context)
classLoader.addServerClass('ch.qos.logback.')
classLoader.addServerClass('org.apache.groovy.')
classLoader.addServerClass('org.slf4j.')
classLoader.addServerClass('org.codehaus.groovy.')
classLoader.addServerClass('groovy.')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ class JettyConfigurerImpl implements JettyConfigurer {
if (webappParams.webXml != null) context.setDescriptor(webappParams.webXml);
FilteringClassLoader classLoader = new FilteringClassLoader(context)
classLoader.addServerClass('ch.qos.logback.')
classLoader.addServerClass('org.apache.groovy.')
classLoader.addServerClass('org.slf4j.')
classLoader.addServerClass('org.codehaus.groovy.')
classLoader.addServerClass('groovy.')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ class TomcatServerConfigurer {
// context.setLogEffectiveWebXml(true) // enable for debugging webxml merge
FilteringClassLoader parentClassLoader = new FilteringClassLoader(params.parentClassLoader ?: this.getClass().getClassLoader())
parentClassLoader.addServerClass('ch.qos.logback.')
parentClassLoader.addServerClass('org.apache.groovy.')
parentClassLoader.addServerClass('org.slf4j.')
parentClassLoader.addServerClass('org.codehaus.groovy.')
parentClassLoader.addServerClass('groovy.')
Expand Down

0 comments on commit 291fd59

Please sign in to comment.