Skip to content

Commit

Permalink
just comments
Browse files Browse the repository at this point in the history
  • Loading branch information
AllinCottrell committed Jan 13, 2025
1 parent f2df144 commit e12d258
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions lib/src/estimate.c
Original file line number Diff line number Diff line change
Expand Up @@ -4213,8 +4213,12 @@ MODEL arma (const int *list, const int *pqlags,

gretl_model_init(&armod, dset);

/* --opg and --hessian cannot be combined */
err = incompatible_options(opt, OPT_G | OPT_H);
if (!err) {
/* --x-13arima cannot be combined with --robust, --stdx or
--lagselect. (Note that --stdx is not documented.)
*/
err = options_incompatible_with(opt, OPT_X, OPT_R | OPT_S | OPT_Z);
}
if (err) {
Expand Down
5 changes: 3 additions & 2 deletions plugin/arma.c
Original file line number Diff line number Diff line change
Expand Up @@ -1243,11 +1243,12 @@ static int set_common_sample (arma_sel *asel, MODEL *amod,

/* Provides built-in means of selecting the AR and MA orders of
an AR(I)MA model via Information Criteria. We accept a general
specification of the form
(p d q)(P D Q)
specification and search over p, q, P and Q, taking their values
on input as maxima; d and D remain clamped at their input values.
and search over p, q, P and Q, taking their values on input as
maxima; d and D remain clamped at their input values.
*/

static int real_arma_select (const int *list, DATASET *dset,
Expand Down

0 comments on commit e12d258

Please sign in to comment.