Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block[disk_stats]: new block #2119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

block[disk_stats]: new block #2119

wants to merge 1 commit into from

Conversation

emersion
Copy link
Contributor

@emersion emersion commented Dec 17, 2024 •
edited
Loading

Reads disk stats from sysfs.

TODO:

  • Write docs
  • Maybe io_stats would be a better name? Or block_device_stats? Not sure.

See: https://docs.kernel.org/admin-guide/iostats.html

@emersion emersion force-pushed the disk-stats branch 2 times, most recently from 20cd87c to 1dd6b38 Compare December 17, 2024 22:31
@emersion
Copy link
Contributor Author

Does any of the maintainers have an opinion on this PR? Is the idea good? Is the name fine? Is the approach taken good enough?

@MaxVerevkin
Copy link
Collaborator

Looks good! Didn't have enough time to explicitly write this sooner, waiting for the docs :)

@emersion emersion force-pushed the disk-stats branch 2 times, most recently from 64786e8 to 8df0fac Compare January 19, 2025 17:45
@emersion
Copy link
Contributor Author

Added docs!

@ammgws
Copy link
Collaborator

ammgws commented Jan 20, 2025

Naming nit - perhaps disk_iostats is better (sincec one might think disk space is a "stat" that should be in disk_stats)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxVerevkin MaxVerevkin MaxVerevkin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersion @MaxVerevkin @ammgws