Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only returns first found not all #28

Closed
jon-nfc opened this issue Aug 9, 2024 · 15 comments · Fixed by nofusscomputing/action_pull_requests#8
Closed

only returns first found not all #28

jon-nfc opened this issue Aug 9, 2024 · 15 comments · Fixed by nofusscomputing/action_pull_requests#8

Comments

@jon-nfc
Copy link

jon-nfc commented Aug 9, 2024

when there is more than one "depends on" within the body of the PR, only the first one is found. see here. All should be returned.

@gregsdennis
Copy link
Owner

It was working fine for me earlier this week. See json-everything/json-everything#775

@gregsdennis
Copy link
Owner

gregsdennis commented Aug 9, 2024

Are you using - or * for the bullets. It doesn't look like * is supported. (I'll fix that.)

Are you saying that only the first open issue/PR is reported, but you expect all open issues/PRs to be reported? (That seems to be working as well.)

@jon-nfc
Copy link
Author

jon-nfc commented Aug 9, 2024

Are you using - or * for the bullets. It doesn't look like * is supported. (I'll fix that.)

Are you saying that only the first open issue/PR is reported, but you expect all open issues/PRs to be reported? (That seems to be working as well.)

using - and use only the first open. see workflow -> https://github.com/nofusscomputing/centurion_erp/actions/runs/10317133439/job/28560748862

@gregsdennis
Copy link
Owner

Yes, I'm looking at that build. I'm not sure why it's only seeing one. If you can post the markdown of that PR, I'll see if I can figure out what's going on.

@jon-nfc
Copy link
Author

jon-nfc commented Aug 9, 2024

the PR is : nofusscomputing/centurion_erp#216

markdown

This PR is to complete the migration from Gitlab to Github

## Links

- Blocked by: https://github.com/nofusscomputing/action_docker/pull/1
- Blocked by: https://github.com/nofusscomputing/action_bump/pull/1
- Blocked By https://github.com/nofusscomputing/action_python/pull/1
- Blocked By: https://github.com/nofusscomputing/action_pull_requests/pull/1
- Related: https://github.com/gregsdennis/dependencies-action/issues/28
- Related: #213 
- Related: #214 

/cc @jasonpagetas 

@gregsdennis
Copy link
Owner

Okay. The problem is the colons: they're not expected. Only the third one doesn't have a colon.

I can fix that, but for now, just remove them.

@jon-nfc
Copy link
Author

jon-nfc commented Aug 9, 2024

Okay. The problem is the colons: they're not expected. Only the third one doesn't have a colon.

I can fix that, but for now, just remove them.

Awesome. Thanks, ill remove for now. I do intend on having them there so await a fix.

@gregsdennis
Copy link
Owner

Alright v1.4.0 is now available. Please close after testing.

@jon-nfc
Copy link
Author

jon-nfc commented Aug 9, 2024

Alright v1.4.0 is now available. Please close after testing.

got an error with it

Current runner version: '2.317.0'
Operating System
Runner Image
Runner Image Provisioner
GITHUB_TOKEN Permissions
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'gregsdennis/dependencies-action@f4fa19405413bddd[2](https://github.com/nofusscomputing/centurion_erp/actions/runs/10317843346/job/28562944523#step:1:2)d49fe258f5b571de44cac09' (SHA:f4fa19405413bddd2d49fe258f5b571de44cac09)
Error: Could not find file '/home/runner/work/_actions/_temp_78243827-fb9f-4212-9c85-e8c32a702aeb/_staging/gregsdennis-dependencies-action-f4fa194/node_modules/.bin/esparse'.

workflow: https://github.com/nofusscomputing/centurion_erp/actions/runs/10317843346/job/28562944523

@gregsdennis
Copy link
Owner

I'll have to look in the morning. Going to bed now.

@jon-nfc
Copy link
Author

jon-nfc commented Aug 9, 2024

Awesome. thanks again for your time. It's appreciated!!

@fmauri-shippypro
Copy link

Same error on our side

@jon-nfc
Copy link
Author

jon-nfc commented Aug 9, 2024

Same error on our side

@fmauri-shippypro I reverted to the prev version until fixed gregsdennis/dependencies-action@4fc2a4879387b43f784920699cb9303dd0524ac4

@gregsdennis
Copy link
Owner

v1.4.1 seems to fix the problem @jon-nfc & @fmauri-shippypro.

I reverted the node pkg updates but kept the action changes.

@jon-nfc
Copy link
Author

jon-nfc commented Aug 10, 2024

G'Day @gregsdennis

Can confirm that v1.4.1 does indeed fix the problem and is working.

action updated with uses: gregsdennis/dependencies-action@ae6e0529ef70f1366a21972f40b1ad0e1b5e3218 # v1.4.1

Thank you for actioning so fast.

jon-nfc added a commit to nofusscomputing/action_pull_requests that referenced this issue Aug 10, 2024
feat(pr_dependency): update dependencies-action 1.3.3 -> v1.4.1

#2 gregsdennis/dependencies-action#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants