-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernization #166
Modernization #166
Conversation
6defe99
to
5ea0879
Compare
5ea0879
to
ac77a1c
Compare
ruby uglify gets confused with some modern js syntax
This is awesome; I just want to do a check myself that the CS to JS matches my own output (if you can let me know if there were any additional changes you made that would be helpful) and I'll get this merged ASAP. |
c82f4d9
to
bc79fca
Compare
quite a bunch has changed when ripping out jquery: ab263ea...364f156 |
don't hurry. please have proper look. i tried to do my best but i'm sure i missed things. |
the click triggers before the change event. if that click event gets its default prevented, the change event will not occur.
@gregschmit any update ? |
mainly adjust to changes in AV::Helpers::Tags::Base see rails/rails#48574
9434a9e
to
7ed5cb2
Compare
i adjusted for rails 7.1. should be ready to be merged. |
Co-authored-by: Slokilla <51393687+Slokilla@users.noreply.github.com>
Co-authored-by: Slokilla <51393687+Slokilla@users.noreply.github.com>
Co-authored-by: Slokilla <51393687+Slokilla@users.noreply.github.com>
Sorry everybody; a lot of crap in my life has conspired to keep me away from this. I am just going to do some basic testing on a demo app (and I'll likely also test this in active scaffold and active admin) to ensure nothing breaks and then I'll merge this. I'm hoping to get to it within the next day or so. |
fwiw, there’s the dummy app that gives you a bunch of selects fo play with. |
Yeah I remembered that as soon as I hit enter -- I was thinking of another project I'm working on where one of my tasks is to build a demo app for it. |
Ok, gonna merge this now as it looks good to me. |
Thanks @glaszig! |
Also thank you @fwininger -- everyone please feel free to @ me on PRs and issues that you believe are important for this project. There are a lot of old PRs so it's hard to separate signal from noise so if you @ me then there's a good chance I'll merge it. |
i realize this is quite a bucket of stuff but i couldn't help myself.
resolves #121, #132.