Wrap EncryptedHelper in interface to reduce Art warnings #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance to get this fixed? It spams my logs! |
|
Any update on this? |
50acbc9 to
7ae79de
Compare
|
Also creating instance via reflection gets rid of the remaining two ART logs. Note: the ART log does not appear on SDK 29. This is only for SDK 28 (which is still a large user base though, so still worth fixing). Edit: also added explicit convenience exception when using encrypted APIs, but not having SQLCipher in classpath, with instructions to set up an encrypted database. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#428
Down to 2. Not seeing a chance to get rid of those...