Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1019 for plotting project growth, but on external-resources branch #1034

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

rando2
Copy link
Contributor

@rando2 rando2 commented Sep 13, 2021

Description of the proposed additions or changes

@mprobson co-authored this PR
We tried to move the ms-stats branch over to external-resources and for some reason it would not let us rebase (other than manually going through each of 4011 commits 😬)
So instead we just moved the code itself over, effectively collapsing it into a single commit.
The revision history will be preserved in #1019 though!

Related issues

#1019

Suggested reviewers (optional)

Checklist

  • Text is formatted so that each sentence is on its own line.
  • Pre-prints cited in this pull request have a GitHub issue opened so that they can be reviewed.

Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving based on my review of the previous branch.

After submitting the DISCO manuscript, I'll work on rerunning this analysis in a workflow and using versioned figures.

@agitter agitter merged commit 2c85371 into external-resources Sep 13, 2021
@agitter agitter deleted the ms-stats-extres branch September 13, 2021 21:01
rando2 added a commit that referenced this pull request Sep 13, 2021
Edits to master branch required for integration of #1034
@rando2 rando2 mentioned this pull request Sep 13, 2021
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Methods Strategies for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants