Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize manuscript/project growth #1019
Visualize manuscript/project growth #1019
Changes from all commits
f930773
051cf81
feb6b92
c0afb29
701bb87
d1d9869
4097f43
6c90ab6
4e18224
16b65e3
1f8e23d
0157828
826ec62
100a617
94a2025
1c9f60f
d01b81b
199b8ca
37c9270
f966e34
ded441f
461c872
8485a01
472267e
427b1d7
5067163
8fe0db9
fc53320
3fbea6b
2ce888a
1b404b8
23e6888
995433d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One way to remove this assumption could be to create a
set
of old and new commits (I understand these are commits' hashes). Then you can process the commits that are new only. Assumbing bothcommits
andoldCommits
are both lists of commits' hashes, it would be something like:commits_to_be_processed = set(commits) - set(oldCommits)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is almost certainly a way to do this with sets, but it would be most straightforward with an ordered set, and it doesn't seem like there's a particularly good way to get that type of data structure in Python (unless I'm missing something!)