Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPE match API tests + small fixes #1074

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Dec 13, 2024

What

Tests are added for the CPE match API, matchCriteriaId is converted to a string for HTTP requests and cpe_last_modified of CPE matches is made optional

Why

The tests were originally omitted from the PR that added the API.

References

GEA-790

Checklist

  • Tests

@timopollmeier timopollmeier requested a review from a team as a code owner December 13, 2024 08:07
@greenbonebot greenbonebot enabled auto-merge (rebase) December 13, 2024 08:07
Copy link

github-actions bot commented Dec 13, 2024

Conventional Commits Report

Type Number
Bug Fixes 2
Added 1

🚀 Conventional commits found.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (721a24b) to head (55e5552).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
+ Coverage   89.92%   90.31%   +0.38%     
==========================================
  Files         108      108              
  Lines        7187     7187              
  Branches      815      815              
==========================================
+ Hits         6463     6491      +28     
+ Misses        521      491      -30     
- Partials      203      205       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timopollmeier timopollmeier force-pushed the add-cpe-match-api-tests branch from c2e7a08 to 5aa73ab Compare December 13, 2024 08:17
@timopollmeier timopollmeier force-pushed the add-cpe-match-api-tests branch from 5aa73ab to d742cdc Compare December 13, 2024 10:28
@timopollmeier timopollmeier marked this pull request as draft December 13, 2024 10:45
@timopollmeier timopollmeier changed the title Add CPE match API tests Add CPE match API tests + small fixes Dec 13, 2024
@timopollmeier timopollmeier marked this pull request as ready for review December 13, 2024 13:59
@timopollmeier timopollmeier force-pushed the add-cpe-match-api-tests branch from 76c8587 to 55e5552 Compare December 13, 2024 14:02
@greenbonebot greenbonebot enabled auto-merge (rebase) December 13, 2024 14:02
@greenbonebot greenbonebot merged commit a215412 into main Dec 13, 2024
21 checks passed
@greenbonebot greenbonebot deleted the add-cpe-match-api-tests branch December 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants