-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPE match API tests + small fixes #1074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
+ Coverage 89.92% 90.31% +0.38%
==========================================
Files 108 108
Lines 7187 7187
Branches 815 815
==========================================
+ Hits 6463 6491 +28
+ Misses 521 491 -30
- Partials 203 205 +2 ☔ View full report in Codecov by Sentry. |
timopollmeier
force-pushed
the
add-cpe-match-api-tests
branch
from
December 13, 2024 08:17
c2e7a08
to
5aa73ab
Compare
timopollmeier
force-pushed
the
add-cpe-match-api-tests
branch
from
December 13, 2024 10:28
5aa73ab
to
d742cdc
Compare
timopollmeier
changed the title
Add CPE match API tests
Add CPE match API tests + small fixes
Dec 13, 2024
timopollmeier
force-pushed
the
add-cpe-match-api-tests
branch
from
December 13, 2024 14:02
76c8587
to
55e5552
Compare
y0urself
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Tests are added for the CPE match API, matchCriteriaId is converted to a string for HTTP requests and cpe_last_modified of CPE matches is made optional
Why
The tests were originally omitted from the PR that added the API.
References
GEA-790
Checklist