Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling for Consider Alive alive test #413

Merged

Conversation

ArnoStiefvater
Copy link
Member

What:

Remove special handling for Consider Alive alive test.

Why:

When Consider Alive is chosen there was still some other ping method applied in the nasl preferences.
This resulted in a wrong print of the chosen alive method on nasl (host_alive_detection.nasl) side when boreas is used.
Boreas is the default now so this special case is not needed anymore.

How:

Do some simple scan.

    gvm-cli --protocol OSP socket --socketpath gbinstall/var/run/ospd-openvas.sock -X "\
    <start_scan scan_id='97079ee9-8917-49da-aa4f-4ef95f757ac1'>\
        <vt_selection>\
            <vt_single id='1.3.6.1.4.1.25623.1.0.100315'>\
                <vt_value id='9'>1</vt_value>\
                <vt_value id='6'>1</vt_value>\
                <vt_value id='3'>1</vt_value>\
            </vt_single>\
        </vt_selection>\
        <targets>\
            <target>\
                <alive_test>8</alive_test>\
                <hosts>127.0.0.1</hosts>\
                <ports>80,8080,443,22</ports>\
                <exclude_hosts></exclude_hosts>\
            </target>\
        </targets>\
        <scanner_params>\
        </scanner_params>\
    </start_scan>"

Without PR Host is alive, Methods used: TCP ping via Boreas Host Alive Scanner is in the results. With applied PR Host is alive, Methods used: ping via Boreas Host Alive Scanner is in the results. This is still not optimal but has to be improved on nasl side and at least does not display wrong information.

Checklist:

@ArnoStiefvater ArnoStiefvater requested a review from a team April 28, 2021 14:19
@Kraemii Kraemii merged commit 5806448 into greenbone:ospd-openvas-21.04 May 3, 2021
ArnoStiefvater added a commit that referenced this pull request May 5, 2021
Remove special handling for Consider Alive alive test (backport #413)
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 26, 2021
…/pr-413

Fix regex of gvmcg titles for get_performance command (backport greenbone#413)
ArnoStiefvater pushed a commit that referenced this pull request Nov 16, 2021
Fix regex of gvmcg titles for get_performance command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants