Remove special handling for Consider Alive alive test #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove special handling for Consider Alive alive test.
Why:
When Consider Alive is chosen there was still some other ping method applied in the nasl preferences.
This resulted in a wrong print of the chosen alive method on nasl (host_alive_detection.nasl) side when boreas is used.
Boreas is the default now so this special case is not needed anymore.
How:
Do some simple scan.
Without PR
Host is alive, Methods used: TCP ping via Boreas Host Alive Scanner
is in the results. With applied PRHost is alive, Methods used: ping via Boreas Host Alive Scanner
is in the results. This is still not optimal but has to be improved on nasl side and at least does not display wrong information.Checklist: