Allow running unittests as root #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you're building a debian package within container.io definition than you tyically do that as root with access to /root/. Therefore it is more reliable to work with a mock than relying on actual access rights on a os while testing.
When running on root test_sudo_available did not check if sudo is available, to enforce check _is_running_as_root needs to be manually set to false.
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
==========================================
- Coverage 85.73% 85.55% -0.18%
==========================================
Files 10 10
Lines 1731 1731
==========================================
- Hits 1484 1481 -3
- Misses 247 250 +3
Continue to review full report at Codecov.
|
jjnicola
approved these changes
Jan 25, 2021
ArnoStiefvater
added a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Update documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Faked path check in
test_create_paren_dirs_failto allow the test to pass even when running those tests as root.Changed
test_sudo_availableto bypass the uid check to allow verifying that sudo is available even when running those tests as root.Why:
While building the debian package within docker the tests will be executed as root.
How:
Run the unittests as root.
Checklist: