Improve logging for unsatisfied vts dependencies #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ospd-openvas-20.08 #336 +/- ##
======================================================
- Coverage 82.71% 81.83% -0.89%
======================================================
Files 9 9
Lines 1481 1519 +38
======================================================
+ Hits 1225 1243 +18
- Misses 256 276 +20
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Sep 15, 2020
ospd_openvas/daemon.py
Outdated
| @@ -717,9 +717,9 @@ def get_dependencies_vt_as_xml_str( | |||
| vt_deps_xml = Element('dependencies') | |||
| for dep in vt_dependencies: | |||
| _vt_dep = Element('dependency') | |||
| try: | |||
| if "1.3.6.1.4.1.25623." in dep: | |||
There was a problem hiding this comment.
Could you please add a global constant for this OID value. From the outside this value is very difficult to understand.
bjoernricks
approved these changes
Sep 16, 2020
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
…-5.7.3 Bump psutil from 5.7.2 to 5.7.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Log the file name of the missing dependency.
Why:
Because it is currently log only the OID of the problematic VT, but not the name of the missing dependency.
How:
Modify a nasl script, adding a typo to an existing dependency. Run openvas -u to update the Redis cache. Run <get_vts/> command. You will see in the logs, the name of the missing deps for the modified nasl plugin.
Checklist: