-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply alive test preferences if one method was selected. #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The selected alive test option overwrite the default settings. The issue was that the preferences where added twice, but always the default ones were used because were found first.
f7a55a6
to
8b37c90
Compare
Codecov Report
@@ Coverage Diff @@
## ospd-openvas-20.08 #334 +/- ##
======================================================
- Coverage 82.71% 81.99% -0.73%
======================================================
Files 9 9
Lines 1481 1516 +35
======================================================
+ Hits 1225 1243 +18
- Misses 256 273 +17
Continue to review full report at Codecov.
|
8b37c90
to
a774bed
Compare
ArnoStiefvater
approved these changes
Sep 10, 2020
FiveOFive
pushed a commit
to FiveOFive/ospd-openvas
that referenced
this pull request
Sep 18, 2020
Apply alive test preferences if one method was selected.
FiveOFive
pushed a commit
to FiveOFive/ospd-openvas
that referenced
this pull request
Sep 18, 2020
Apply alive test preferences if one method was selected.
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
….6.1 Bump lxml from 4.5.2 to 4.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The selected alive test option overwrite the default settings.
Why:
The issue was that the preferences where added twice, but always
the default ones were used because were found first.
How:
Run a scan with some alive test method different to the default one. An easy tests is to select "consider alive" against a dead hosts.
Checklist: