Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply alive test preferences if one method was selected. #334

Merged
merged 6 commits into from
Sep 10, 2020

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Sep 10, 2020

What:
The selected alive test option overwrite the default settings.

Why:
The issue was that the preferences where added twice, but always
the default ones were used because were found first.

How:
Run a scan with some alive test method different to the default one. An easy tests is to select "consider alive" against a dead hosts.

Checklist:

The selected alive test option overwrite the default settings.
The issue was that the preferences where added twice, but always
the default ones were used because were found first.
@jjnicola jjnicola force-pushed the alive-test branch 3 times, most recently from f7a55a6 to 8b37c90 Compare September 10, 2020 12:52
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #334 into ospd-openvas-20.08 will decrease coverage by 0.72%.
The diff coverage is 62.50%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           ospd-openvas-20.08     #334      +/-   ##
======================================================
- Coverage               82.71%   81.99%   -0.73%     
======================================================
  Files                       9        9              
  Lines                    1481     1516      +35     
======================================================
+ Hits                     1225     1243      +18     
- Misses                    256      273      +17     
Impacted Files Coverage Δ
ospd_openvas/daemon.py 62.01% <31.81%> (-0.90%) ⬇️
ospd_openvas/db.py 96.24% <57.14%> (-3.36%) ⬇️
ospd_openvas/preferencehandler.py 87.88% <86.36%> (+0.78%) ⬆️
ospd_openvas/__version__.py 100.00% <100.00%> (ø)
ospd_openvas/lock.py 85.96% <100.00%> (+0.25%) ⬆️
ospd_openvas/nvticache.py 98.49% <100.00%> (+0.01%) ⬆️
ospd_openvas/openvas.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90746aa...eed0626. Read the comment docs.

@jjnicola jjnicola marked this pull request as ready for review September 10, 2020 13:02
@jjnicola jjnicola merged commit 9e04941 into greenbone:ospd-openvas-20.08 Sep 10, 2020
@jjnicola jjnicola deleted the alive-test branch September 10, 2020 14:04
FiveOFive pushed a commit to FiveOFive/ospd-openvas that referenced this pull request Sep 18, 2020
Apply alive test preferences if one method was selected.
FiveOFive pushed a commit to FiveOFive/ospd-openvas that referenced this pull request Sep 18, 2020
Apply alive test preferences if one method was selected.
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants