Use flock for the feed lock file instead of just looking for existence. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernricks
suggested changes
May 14, 2020
Use Path.open() instead of open() Update test to use the mocked assert_called_once()
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 82.26% 82.33% +0.06%
==========================================
Files 9 9
Lines 1438 1455 +17
==========================================
+ Hits 1183 1198 +15
- Misses 255 257 +2
Continue to review full report at Codecov.
|
bjoernricks
reviewed
May 15, 2020
ospd_openvas/lock.py
Outdated
| try: | ||
| self._fd.close() | ||
| self._fd = None | ||
| except (AttributeError, TypeError): |
There was a problem hiding this comment.
Can't self._fd.close() raise other errors then AttributeError or TypeError ?
bjoernricks
reviewed
May 15, 2020
bjoernricks
approved these changes
May 15, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.