Modify handling of dead hosts. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 81.84% 82.26% +0.41%
==========================================
Files 9 9
Lines 1449 1438 -11
==========================================
- Hits 1186 1183 -3
+ Misses 263 255 -8
Continue to review full report at Codecov.
|
mattmundell
approved these changes
May 7, 2020
|
I tried the patch and it accelerates my Host Discovery scan substantially. |
Therefore the host progress is marked as -1
…single host list. This reduce the amount of memory used for storing the dead hosts and the processing time. No messages HOST_START, dead host, HOST_END are sent to the client if the dead hosts are handle in batch. This is the method use by Boreas method in OpenVAS.
…shed() A finished host at this point could be alive or dead. Depending on the host progress it will be set as dead or alive(finished).
Finished hosts are only for progress calculation. Only the host in the exclude host list will not be scanned. When resuming a stopped task, the client should sent in the exclude host list, the list of host to exclude, and the list of finished host, if they must not be scanned again.
bjoernricks
suggested changes
May 11, 2020
Also catch TypeError when cast the progress value to float.
bjoernricks
approved these changes
May 11, 2020
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
…-poetry Replace pipenv with poetry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR greenbone/ospd#266
A finished host could be alive or dead, when the classic alive test method is uses.
Depending on the host progress it will be set as dead or alive(finished).
When Boreas is used, do not send log and host details message of dead hosts to the client.
In any case, the dead host are not taken in account for the scan progress calculation