Send messages generated by the scanner main process. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove trailing whitespaces from the host and OID strings.
Codecov Report
@@ Coverage Diff @@
## ospd-openvas-1.0 #171 +/- ##
===================================================
- Coverage 71.47% 71.4% -0.08%
===================================================
Files 4 4
Lines 1013 1014 +1
===================================================
Hits 724 724
- Misses 289 290 +1
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Dec 3, 2019
| @@ -1507,6 +1507,7 @@ def exec_scan(self, scan_id, target): | |||
|
|
|||
| ctx = self.openvas_db.kb_connect(self.main_kbindex) | |||
| self.openvas_db.set_redisctx(ctx) | |||
| self.get_openvas_result(scan_id, "") | |||
There was a problem hiding this comment.
The method name is confusing. A better name would be something like collect_results_from_openvas.
|
@bjoernricks , Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove trailing whitespaces from the host and OID strings.
Update test accordingly