Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Add set_nvticache_str(). #151

Merged
merged 5 commits into from
Nov 15, 2019

Conversation

jjnicola
Copy link
Member

It only backports set_nvticache_str() method from PR #150
Tests and supported nvticache version are dependent on the releases.

The nvticache name in redis (dependent on the gvm-libs) will be checked
for compatibility against a list of supported nvticache versions.
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #151 into ospd-openvas-1.0 will increase coverage by 0.35%.
The diff coverage is 90%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           ospd-openvas-1.0     #151      +/-   ##
====================================================
+ Coverage              71.1%   71.45%   +0.35%     
====================================================
  Files                     4        4              
  Lines                   976      995      +19     
====================================================
+ Hits                    694      711      +17     
- Misses                  282      284       +2
Impacted Files Coverage Δ
ospd_openvas/daemon.py 59.71% <100%> (+0.05%) ⬆️
ospd_openvas/nvticache.py 96.26% <89.47%> (-1.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1102abc...48a06e2. Read the comment docs.

@jjnicola jjnicola marked this pull request as ready for review November 13, 2019 09:45
@bjoernricks bjoernricks merged commit 8b3383c into greenbone:ospd-openvas-1.0 Nov 15, 2019
@jjnicola jjnicola deleted the nvticache-1 branch November 15, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants