Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 161] adding tool to update tags of native rules with our custom tags #14

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

dedece35
Copy link
Member

@dedece35 dedece35 commented Dec 13, 2022

cf cnumr/ecoCode#161
(@Silicoman and @MP-Aubay)

description of this new tool : cf readme.md in tools_init directory.

please make a review : @jules-delecour-dav , @jhertout

@dedece35 dedece35 added the 🚀 enhancement New feature or request label Dec 13, 2022
@dedece35 dedece35 merged commit 11adde2 into main Dec 15, 2022
@Silicoman
Copy link
Contributor

Hi,

I have testing your script on ubuntu. It's needed jq. sudo apt install jq as requirement to not log error.

After looking your MR, I was thinking to :

  • make a maven module : /src/main/scripts to release sh scripts ( freeze use API, rules)
  • create a resource file dedicaced to rules to include to your script formated like a table with description.

Sorry to not have reply before and thanks for your contribution :)

@dedece35
Copy link
Member Author

hi @Silicoman
thank you for reviewing !

  • good idea for table with description : feel free to upgrade this system (not yet used, that's why i alreasy merged into main)
  • regarding idea to create a new maven module, why not, but if you want to freeze rules / api dev and seperate life cycles, a maven module is not sufficent because these tools will be released with all other maven modules in ´ecocode´ repository. I think a better way should be a new repository for these kind of tools. indeed, these tools will be uses for ´ecocode' plugin and ´ecocode-mobile´ plugin which are in seperated repositories.

@utarwyn utarwyn deleted the ISSUE_161_toolInitSonarTags branch March 28, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants