Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(design): added docs for checkbox #953

Closed
wants to merge 2 commits into from
Closed

docs(design): added docs for checkbox #953

wants to merge 2 commits into from

Conversation

Nolan-Arnold
Copy link
Contributor

@Nolan-Arnold Nolan-Arnold commented Jun 23, 2020 •
edited by xelaint
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Part of: #336

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

@Nolan-Arnold Nolan-Arnold requested a review from a team as a code owner June 23, 2020 01:54
xelaint
xelaint requested changes Jun 23, 2020
View reviewed changes
libs/design/src/atoms/form/checkbox/checkbox.md Outdated Show resolved Hide resolved
libs/design/src/atoms/form/checkbox/checkbox.md Outdated Show resolved Hide resolved
@xelaint xelaint added package: design @daffodil/design docs This issue is related to documentation labels Jun 23, 2020
@xelaint xelaint added this to the v0.4.0 - The Big Docs update milestone Jun 23, 2020
@xelaint xelaint removed the package: design @daffodil/design label Jun 23, 2020
xelaint
xelaint requested changes Jul 8, 2020
View reviewed changes
libs/design/src/atoms/form/checkbox/checkbox.md

The `DaffCheckboxComponent` uses native `<input>` HTML elements to ensure an accesible experience by default.

## DaffCheckbox Properties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkbox Properties

libs/design/src/atoms/form/checkbox/checkbox.md
Output | becameChecked | boolean | An event that emits when the `checked` input becomes `true`. |
Output | becameUnchecked | boolean | An event that emits when the `checked` input becomes `false`. |

## DaffCheckboxSet Properties
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkbox Set Properties

libs/design/src/atoms/form/radio/radio.md Outdated Show resolved Hide resolved
@xelaint
Copy link
Member

xelaint commented Jul 8, 2020

Additionally, I think these should be split into two PRs.

@Nolan-Arnold Nolan-Arnold force-pushed the checkbox-radio-guides branch from 73d1c0f to 8f7517f Compare July 13, 2020 19:36
@Nolan-Arnold Nolan-Arnold changed the title docs(design): added guides for checkbox and radio docs(design): added docs for checkbox Jul 13, 2020
@Nolan-Arnold
Copy link
Contributor Author

Additionally, I think these should be split into two PRs.

Okay split into checkbox PR here, and radio here #998.

@xelaint
Copy link
Member

xelaint commented Jul 14, 2020

@Nolan-Arnold there are still a few changes that need to be made from my review a few days ago.

@xelaint
Copy link
Member

xelaint commented Sep 14, 2020

@Nolan-Arnold bumping this for updates.

@xelaint
Copy link
Member

xelaint commented Jan 26, 2021

@Nolan-Arnold bumping this. There are few change requests that haven't been addressed yet.

@xelaint xelaint mentioned this pull request Jan 28, 2021
Closed
3 tasks
@damienwebdev damienwebdev added the package: design @daffodil/design label Mar 4, 2021
@damienwebdev damienwebdev self-assigned this Jul 28, 2021
@damienwebdev
Copy link
Member

Closing as this is hella stale.

@damienwebdev damienwebdev deleted the checkbox-radio-guides branch July 29, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xelaint xelaint xelaint requested changes

Assignees

@damienwebdev damienwebdev

@xelaint xelaint

@Nolan-Arnold Nolan-Arnold

Labels
docs This issue is related to documentation package: design @daffodil/design
Projects
None yet
Milestone
v0.4.0 - The Big Docs update
Development

Successfully merging this pull request may close these issues.
3 participants
@Nolan-Arnold @xelaint @damienwebdev