Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(daffio): add sidebar mode switching to docs #414

Closed
wants to merge 1 commit into from

Conversation

damienwebdev
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, we don't show the sidebar on the docs.

Touches: #336

What is the new behavior?

We will now show the sidebar in side mode.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

This breaks the states outlined in the DaffSidebarAnimationStates. It also position:absolute's the side mode. These are potentially UI breaking. If you use these states, you'll need to refactor to the new states.

@damienwebdev damienwebdev added package: daff.io @daffodil/daff.io package: design @daffodil/design labels Aug 30, 2019
@damienwebdev damienwebdev requested review from a team as code owners August 30, 2019 14:01
@damienwebdev damienwebdev deleted the docs_sidebar branch September 2, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

3 participants