This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Fix grammar for non/interactive session event log #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webvictim
reviewed
Jul 15, 2020
| @@ -397,13 +397,13 @@ export const formatters: Formatters = { | |||
| event.server_hostname || event.server_addr || event.server_id; | |||
|
|
|||
| if (!event.interactive) { | |||
| return `User [${user}] has ended non-interactive session [${event.sid}] on node [${node}] `; | |||
| return `User [${user}] has ended an non-interactive session [${event.sid}] on node [${node}] `; | |||
There was a problem hiding this comment.
This should be a non-interactive session rather than an non-interactive session
alex-kovoy
approved these changes
Jul 15, 2020
webvictim
approved these changes
Jul 15, 2020
...eport/src/cluster/components/Audit/AuditEvents/__snapshots__/AuditEvents.story.test.tsx.snap
Outdated
Show resolved
Hide resolved
...eport/src/cluster/components/Audit/AuditEvents/__snapshots__/AuditEvents.story.test.tsx.snap
Outdated
Show resolved
Hide resolved
webvictim
approved these changes
Jul 15, 2020
russjones
pushed a commit
that referenced
this pull request
Jul 20, 2021
russjones
pushed a commit
that referenced
this pull request
Jul 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves gravitational/teleport#4051
fixes gravitational/teleport#4035
Description
Screenshot
grammar correction:
vertical/horizontal scrollbar:
