[v17] Workload Identity Revocations Signing (#52353) #52503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add initial implementation of CRL signing * Clarify * Add basic support for streaming signed CRL to `tctl` * Add log messages * Start adding CRL support to tbot * Wire in CRL support to workload-identity-x509 * Wire up crlCache to dependent services * Fix missing cluster name injectiont * Run the background goroutine * FIx notification mechanism * Add CRL assertions to TestBotWorkloadIdentityX509 * Add appropriate backoff to RevocationService * Start work on TestRevocationService_CRL * Change comparison in test * Finish TestRevocationService_CRL * Add CRL assertion to TestBotWorkloadIdentityAPI * Fix linter complaint * Update lib/tbot/service_workload_identity_api_test.go Co-authored-by: Dan Upton <daniel.upton@goteleport.com> * Update lib/tbot/service_workload_identity_api_test.go Co-authored-by: Dan Upton <daniel.upton@goteleport.com> * Rename KeyStorer * Trigger CRL signing every ten minutes * ADd SVIDCRLPemPath to Describe --------- Co-authored-by: Dan Upton <daniel.upton@goteleport.com>
marcoandredinis
approved these changes
Feb 26, 2025
boxofrad
approved these changes
Feb 26, 2025
ryanclark
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #52353
changelog: Added support for X509 revocations to Workload Identity.