Fix violations of non-constant format strings linter

[rosstimothy]

Depends on https://github.com/gravitational/teleport.e/pull/6006. Now that we are compliant, the ignore rule was removed from the golangci-lint config to prevent future regressions.

[codingllama]

Many thanks, I confess I hesitated fixing this one when I saw how many occurrences there were.

I would swap all trace.Foo("%s", err.Error()) calls for just trace.Foo("%s", err). In practice it makes little difference, but I think the latter is the better idiom (and this will be heavily copied).

Various helpers have awful signatures like ConvertFoo(err error, args ...any) error, which begs the question of what one is supposed to do with args. I suggest cutting args and pushing whatever extra-information to the caller instead - they can "%w" or trace.Wrap or something else.

[creack]

Not a big fan if all the trace.Foo("%s", err) as there is no way to unwrap. May be interesting to add %w support in trace, but out of scope here.

[rosstimothy]

Not a big fan if all the trace.Foo("%s", err) as there is no way to unwrap. May be interesting to add %w support in trace, but out of scope here.

Agreed. We need to make some time to reimagine trace to better interoperate with Go's changes to error wrapping.

[tigrato]

Not a big fan if all the trace.Foo("%s", err) as there is no way to unwrap. May be interesting to add %w support in trace, but out of scope here.

Agreed. We need to make some time to reimagine trace to better interoperate with Go's changes to error wrapping.

But this PR doesn't change anything. Prior we would just fmt.Sprinf(err) 😿

[codingllama]

Not a big fan if all the trace.Foo("%s", err) as there is no way to unwrap. May be interesting to add %w support in trace, but out of scope here.

Agreed. We need to make some time to reimagine trace to better interoperate with Go's changes to error wrapping.

https://pkg.go.dev/github.com/codingllama/semerr#pkg-overview (there's only so much I can resist.)