-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vnet] windows ip and route configuration #51690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"golang.zx2c4.com/wireguard/tun" | ||
) | ||
|
||
const ( | ||
tunInterfaceName = "TeleportVNet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we can reuse the service name defined in https://github.com/gravitational/teleport/blob/master/lib/vnet/service_windows.go#L36.
If we want a different name for the tun, maybe spell out TeleportVNetTUN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i'll leave it as-is they are separate concepts that just happen to be the same string, i prefer naming the TUN interface just TeleportVNet
c3e05c8
to
d646d38
Compare
cfff7f3
to
af60426
Compare
d646d38
to
0dee98d
Compare
af60426
to
4c4d5d3
Compare
This PR adds OS configuration for VNet on Windows. Specifically, the TUN interface is now configured with a V6 and V4 IP address, and IP routes are configured so that IP packets in the VNet IP ranges for each cluster are routed to the TUN interface and handled by VNet. This PR does *not* configure the VNet DNS nameserver on Windows, that will come in a following PR. With these changes, VNet kind of works, without DNS. You can manually query the IP address of VNet's DNS server and get back a v4 and v6 address for the app. TCP connections to either of these addresses then work for connecting to the app.
4c4d5d3
to
9b6d12f
Compare
@nklaassen See the table below for backport results.
|
Backport #51690 to branch/v17
Backport #51690 to branch/v17
Backport #51690 to branch/v17
Backport #51690 to branch/v17
This PR adds OS configuration for VNet on Windows. Specifically, the TUN interface is now configured with a V6 and V4 IP address, and IP routes are configured so that IP packets in the VNet IP ranges for each cluster are routed to the TUN interface and handled by VNet. This PR does *not* configure the VNet DNS nameserver on Windows, that will come in a following PR. With these changes, VNet kind of works, without DNS. You can manually query the IP address of VNet's DNS server and get back a v4 and v6 address for the app. TCP connections to either of these addresses then work for connecting to the app.
Part of RFD 195.
This PR adds OS configuration for VNet on Windows. Specifically, the TUN interface is now configured with a V6 and V4 IP address, and IP routes are configured so that IP packets in the VNet IP ranges for each cluster are routed to the TUN interface and handled by VNet.
This PR does not configure the VNet DNS nameserver on Windows, that will come in a following PR.
With these changes, VNet kind of works, without DNS. You can manually query the IP address of VNet's DNS server and get back a v4 and v6 address for the app. TCP connections to either of these addresses then work for connecting to the app.