Okta API: Remove unused fields and update docs #51637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd729db to
daa35a2
Compare
zmb3
requested changes
Jan 30, 2025
zmb3
approved these changes
Jan 30, 2025
smallinsky
approved these changes
Jan 30, 2025
smallinsky
reviewed
Jan 30, 2025
| @@ -84,6 +84,8 @@ breaking: | |||
| ignore: | |||
| # TODO(codingllama): Remove ignore once the PDP API is stable. | |||
| - api/proto/teleport/decision/v1alpha1 | |||
| # TODO(kopiczko) remove after https://github.com/gravitational/teleport/pull/51637 is merged | |||
There was a problem hiding this comment.
Nit: Please don’t forget to remove it as soon as the PR lands in master :-)
I recall correctly, the Update endpoint has not been backported to v17 yet, so the release branches should not be affected
daa35a2 to
6fc264a
Compare
kopiczko
added a commit
that referenced
this pull request
Jan 31, 2025
Restore field order after #51637. It turned out those fields got to v17.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Restore field order in UpdateIntegrationRequest proto Restore field order after #51637. It turned out those fields got to v17. * Add temporary protobuf liter exception
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
* Okta API: Remove unused fields and update docs * Add temporary protobuf liter exception
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
This reverts commit 6fc264a from PR gravitational#51637.
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…51709) * Restore field order in UpdateIntegrationRequest proto Restore field order after gravitational#51637. It turned out those fields got to v17. * Add temporary protobuf liter exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
app_namefield in plugin settings and status (this field is not yet set inebut the value is copied over from settings to status, so it should be the same thing in the docs)UpdateIntegraitonRequest(compatibility is broken, but this request is not yet used)