[teleport-update] Add proper healthcheck for agents #51613
+251
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be7af20 to
3ed4944
Compare
espadolini
reviewed
Jan 30, 2025
| @@ -55,8 +56,9 @@ func NewClient(socketPath string) *Client { | |||
| clt: &http.Client{ | |||
There was a problem hiding this comment.
While you're here, could you also add a CheckRedirect that errors unconditionally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing, @hugoShaka found that the PID crash detection logic implemented in teleport-update does not catch various failure scenarios where Teleport will repeatedly attempt to reconnect without crashing due to a bug.
This PR adds a readiness check on Teleport's debug socket. @hugoShaka is working on a separate PR in parallel to prevent the readiness endpoint from being disabled.
Instead of monitoring the PID for 30 seconds,
teleport-updatenow waits 60 seconds for the process to start, stabilize, and return 200 from /readyz. If the PID file is missing, socket is missing, or /readyz isn't implemented, the corresponding check is disabled with a warning.The
teleport-updatebinary will be used to enable, disable, and trigger automatic Teleport agent updates. The new auto-updates system manages a local installation of the cluster-specified version of Teleport stored in/opt/teleport.RFD: #47126
Goal (internal): https://github.com/gravitational/cloud/issues/10289