[v16] backport common decision service elements #51611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clone protos from fspmarshall/pdp-work-02 * Use decisionpb as the Go package alias * Update DecisionService docs * Split identity protos into separate files * Update Metadata docs * Split metadata into separate files * Update Resource docs * Update database access docs and fields * Update SSH access docs and fields * Ignore breaking changes on decision protos * Update generated protos * Use teleport.trait.v1.Trait * Document mutual dependency between "ResourceID" types * nit: s/ResourceID/ResourceId * nit: Use the correct CamelCase field name in comments * Update generated protos * Add RouteToApp.target_port * Update generated protos * Update comments on TLSIdentity / tlsca.Identity * Update generated protos
* Add the decisionv1.Service boilerplate * Wire decisionv1.Service to auth.GRPCServer * Wire decisionpb.DecisionServiceClient to client.Client * Add basic service testing
* Add conversions to/from decisionpb.TLSIdentity
* Map timestamppb.Timestamp{} to 0-0-0 0:0.0 (instead of unix epoch)
* Document that slices are not deep-copied
* Add EvaluateDatabaseAccessRequest.database * Update generated protos
codingllama
approved these changes
Jan 29, 2025
rosstimothy
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #49875, #49912, #50308, and #50481 to branch/v16.
Explanation: initial development of the decision service happened only on master, but we are starting to make changes to code outside of the
decisionpackages. Some of these changes will be significant enough that not backporting them to all release branches would cause an unacceptable level of divergence and lead to significant issues for unrelated backports going forward.