[vnet] run networking stack on Windows #51280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d197ac to
7f8b0b3
Compare
9503952 to
70fb809
Compare
7f8b0b3 to
375602d
Compare
7779e33 to
a3eda59
Compare
5486ab6 to
a80b639
Compare
a3eda59 to
0c5517f
Compare
a80b639 to
6086c59
Compare
6644c87 to
e46225e
Compare
ravicious
approved these changes
Jan 27, 2025
flyinghermit
approved these changes
Jan 28, 2025
Comment on lines
+111
to
+114
| // TODO(nklaassen): implement process authentication. | ||
| return nil |
There was a problem hiding this comment.
Should we return trace.NotImplemented for now?
There was a problem hiding this comment.
this is all a work in progress, for now i'd like to leave it as nil so i can actually see the process running and not just immediately exiting with an error
Comment on lines
21
to
34
| type OSUpstreamNameserverSource struct{} | ||
|
|
||
| func NewOSUpstreamNameserverSource() (*OSUpstreamNameserverSource, error) { | ||
| return &OSUpstreamNameserverSource{}, nil | ||
| } | ||
|
|
||
| func (s *OSUpstreamNameserverSource) UpstreamNameservers(ctx context.Context) ([]string, error) { |
There was a problem hiding this comment.
Where are these used?
There was a problem hiding this comment.
added some comments
f34a5a6 to
7ad0064
Compare
e46225e to
493aaf0
Compare
71320a1 to
26899bf
Compare
|
@nklaassen See the table below for backport results.
|
nklaassen
added a commit
that referenced
this pull request
Jan 29, 2025
Backport #51280 to branch/v17
nklaassen
added a commit
that referenced
this pull request
Jan 29, 2025
Backport #51280 to branch/v17
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
Backport #51280 to branch/v17
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
* [vnet] run networking stack on Windows * respond to review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of RFD 195.
This PR builds on top of the remote app provider added in #51279 to create the gRPC connection between the windows service and the user process/client application, and use the remote app provider to start the VNet networking stack on Windows.
I'm not yet configuring any routing or DNS resolvers on Windows, so it doesn't actually do anything, but it's one step in the process.