Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OIDC auth functionality to the Azure integration #51219

Merged
merged 46 commits into from
Jan 23, 2025
Merged

Adding OIDC auth functionality to the Azure integration #51219

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
36429b9
Protobuf and configuration for Access Graph Azure Discovery
mvbrock Dec 17, 2024
59c9049
Fixing rebase after protobuf gen
mvbrock Dec 18, 2024
f6ddddf
Updating to use existing msgraph client
mvbrock Dec 19, 2024
d2f2ba7
PR feedback
mvbrock Dec 20, 2024
6c68433
Using variadic options
mvbrock Jan 6, 2025
9788436
Removing memberOf expansion
mvbrock Jan 6, 2025
3a49525
Expanding memberships by calling memberOf on each user
mvbrock Jan 7, 2025
0322a83
PR feedback
mvbrock Jan 9, 2025
de61214
Rebase go.sum stuff
mvbrock Jan 9, 2025
cb6b8f5
Go mod tidy
mvbrock Jan 9, 2025
c9aff9f
Fixing go.mod
mvbrock Jan 9, 2025
f2f9634
Update lib/msgraph/paginated.go
mvbrock Jan 10, 2025
856e66d
PR feedback
mvbrock Jan 10, 2025
d1569e3
Protobuf and configuration for Access Graph Azure Discovery
mvbrock Dec 17, 2024
d012d54
Adding Azure sync functionality which can be called by the Azure fetcher
mvbrock Dec 17, 2024
c40a317
Protobuf update
mvbrock Dec 18, 2024
9c4431a
Linting
mvbrock Jan 13, 2025
0a7bf93
PR feedback
mvbrock Jan 15, 2025
4a32974
PR feedback
mvbrock Jan 16, 2025
df95f49
Updating to use existing msgraph client
mvbrock Dec 19, 2024
34367b8
PR feedback
mvbrock Dec 20, 2024
888fb06
Using variadic options
mvbrock Jan 6, 2025
76e5f4f
Removing memberOf expansion
mvbrock Jan 6, 2025
1651a36
Expanding memberships by calling memberOf on each user
mvbrock Jan 7, 2025
65e7687
PR feedback
mvbrock Jan 9, 2025
2697287
Rebase go.sum stuff
mvbrock Jan 9, 2025
c238a39
PR feedback
mvbrock Jan 10, 2025
faec959
Protobuf and configuration for Access Graph Azure Discovery
mvbrock Dec 17, 2024
a166e79
Protobuf gen fix
mvbrock Dec 18, 2024
a6f03f7
Rebase fixes
mvbrock Jan 22, 2025
7aeab0f
More cleanup
mvbrock Jan 22, 2025
1e35ed2
e ref update
mvbrock Jan 10, 2025
e2f6e24
Invoking token generation and returning the response
mvbrock Jan 18, 2025
dc9c000
Quick test with a message to make sure RPC is invoked
mvbrock Jan 18, 2025
738cee6
Skeleton of new Azure OIDC RPC call
mvbrock Jan 18, 2025
71ce322
Fetching the Azure OIDC token during fetcher creation and establishin…
mvbrock Jan 19, 2025
5a60068
PR feedback; restricting token requests to auth, discovery, and proxy…
mvbrock Jan 21, 2025
dc04d94
Lint
mvbrock Jan 22, 2025
7242fba
Fixing mocks
mvbrock Jan 22, 2025
384ab8f
Fix imports
mvbrock Jan 22, 2025
8093659
Fix test
mvbrock Jan 22, 2025
770cafc
Rebase fxes
mvbrock Jan 23, 2025
ebcdab8
Adding back OIDC fetching, accidentally removed it during rebase
mvbrock Jan 23, 2025
da36e40
e ref
mvbrock Jan 23, 2025
31064b0
Lint
mvbrock Jan 23, 2025
696d4aa
Fix imports
mvbrock Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR feedback
  • Loading branch information
@mvbrock
mvbrock committed Jan 23, 2025
commit d2f2ba7c773abc255442dae304086b0f5cd81979
2 changes: 1 addition & 1 deletion lib/integrations/azureoidc/accessgraph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func CreateTAGCacheFile(ctx context.Context) error {
}

cache := &TAGInfoCache{}
err = graphClient.IterateApplications(ctx, func(app *msgraph.Application) bool {
err = graphClient.IterateApplications(ctx, nil, func(app *msgraph.Application) bool {
appID := app.AppID
if appID == nil {
slog.WarnContext(ctx, "app ID is nil", "app", app)
Expand Down
4 changes: 2 additions & 2 deletions lib/msgraph/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ func TestIterateUsers_Empty(t *testing.T) {
baseURL: uri,
pageSize: defaultPageSize,
}
err = client.IterateUsers(context.Background(), func(*User) bool {
err = client.IterateUsers(context.Background(), nil, func(*User) bool {
assert.Fail(t, "should never get called")
return true
})
Expand Down Expand Up @@ -215,7 +215,7 @@ func TestIterateUsers(t *testing.T) {
}

var users []*User
err = client.IterateUsers(context.Background(), func(u *User) bool {
err = client.IterateUsers(context.Background(), nil, func(u *User) bool {
users = append(users, u)
return true
})
Expand Down