-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump Go to v1.23.5 #51136
Merged
Merged
chore: Bump Go to v1.23.5 #51136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
approved these changes
Jan 16, 2025
hugoShaka
approved these changes
Jan 16, 2025
public-teleport-github-review-bot
bot
removed request for
bernardjkim and
rosstimothy
January 16, 2025 21:44
Due to the recent net/http changes TestThumbprint now breaks. I could update the thumbprint, but I take issue with the test depending on Go internals to begin with. @marcoandredinis, could we change the test so it relies on some cert we define instead? |
rosstimothy
approved these changes
Jan 16, 2025
Should be fixed here |
marcoandredinis
approved these changes
Jan 17, 2025
Rebasing to get the unit test fix |
marcoandredinis
force-pushed
the
codingllama/bump-go
branch
from
January 17, 2025 12:19
aebf6e6
to
7e3526e
Compare
@codingllama See the table below for backport results.
|
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Go to the latest patch.
Changelog: Updated Go to 1.23.5