Remove EICE dead code #51107
Merged
Remove EICE dead code #51107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
commented
Jan 16, 2025
| /> | ||
| </EditorWrapper> | ||
| ); | ||
| // TODO(marco): should we remove `ec2` from the AwsResourceKind? |
There was a problem hiding this comment.
Can someone please help me here?
0f87eb7 to
8f703e3
Compare
Can you just clarify what releases in the PR body just in case anyone needs to know in the future? |
Edited the PR description to include the PR that removed the screen. |
ryanclark
approved these changes
Jan 16, 2025
flyinghermit
approved these changes
Jan 16, 2025
| @@ -200,6 +200,8 @@ func (s *AWSOIDCService) awsClientReq(ctx context.Context, integrationName, regi | |||
| } | |||
|
|
|||
| // ListEICE returns a paginated list of EC2 Instance Connect Endpoints. | |||
| // | |||
| // Deprecated: Marked as deprecated in teleport/integration/v1/awsoidc_service.proto. | |||
There was a problem hiding this comment.
Add Delete schedule for these deprecated methods?
We usually add DELETE IN vX comment.
There was a problem hiding this comment.
I'll schedule them to be deleted in v19
Accessing EC2 instances using EC2 Instance Connect Endpoint was developed some releases ago. However, due to strict quotas put in place by amazon, we decide to remove this feature. Since a couple of releases ago we hide this feature from the UI. This PR removes dead code: - removes the UI bits used during the Discovery flow - removes the `teleport integrationn configure eice-iam` command - removes API endpoinst that are no longer used - deprecates the unused gRPC calls The following parts were kept, to ensure we don't break existing set ups: - auto discovery of ec2 instances using the EICE method - accessing Servers which have the ec2-ice subkind - kubernetes operator and terraform provider EICE resource management We might remove those in the future, but for now, they will be kept.
8f703e3 to
3d5d8a3
Compare
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
* Remove EICE dead code Accessing EC2 instances using EC2 Instance Connect Endpoint was developed some releases ago. However, due to strict quotas put in place by amazon, we decide to remove this feature. Since a couple of releases ago we hide this feature from the UI. This PR removes dead code: - removes the UI bits used during the Discovery flow - removes the `teleport integrationn configure eice-iam` command - removes API endpoinst that are no longer used - deprecates the unused gRPC calls The following parts were kept, to ensure we don't break existing set ups: - auto discovery of ec2 instances using the EICE method - accessing Servers which have the ec2-ice subkind - kubernetes operator and terraform provider EICE resource management We might remove those in the future, but for now, they will be kept. * add delete version notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing EC2 instances using EC2 Instance Connect Endpoint was developed some releases ago:
However, due to strict quotas put in place by amazon, we decide to remove this feature.
Since v15.4.0 we hide this feature from the UI. This PR removes dead code:
teleport integrationn configure eice-iamcommandThe following parts were kept, to ensure we don't break existing set ups:
We might remove those in the future, but for now, they will be kept.