Hide specific features from nav is dashboard tenant #51103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyinghermit
approved these changes
Jan 16, 2025
rudream
approved these changes
Jan 16, 2025
mcbattirola
reviewed
Jan 16, 2025
| // are usually "always visible" | ||
| export function shouldHideFromNavigation(cfg: { | ||
| isTeam: boolean; | ||
| isUsageBasedBilling: boolean; |
There was a problem hiding this comment.
Most subscriptions nowadays should have isUsageBasedBilling=true IIRC. The main exceptions are OSS and 14-day trials.
This means that shouldHideFromNavigation will return true for most customers, is this what we want?
| // However, there are some cases where hiding the feature is explicitly requested. Use this as a backdoor to hide the features that | ||
| // are usually "always visible" | ||
| export function shouldHideFromNavigation(cfg: { | ||
| isTeam: boolean; |
There was a problem hiding this comment.
I think isTeam is hardcoded to false now, we use instead isStripeManaged.
We refactored things not to need to check isStripeManaged most of the time. We should use the entitlements instead. So I think we can remove isTeam from this function.
For reference, isStripeManaged is used for Stripe-specific things, like showing a UI to add a credit card, downloading invoices, etc.
This PR makes an update to our logic to the "backdoor" that would keep things hidden after making updates to show most of the features to promote discoverability. Currently, we only continued to hide them if their license specified it, but this incorrectly ignored dashboard, usage based, and team tenants as well.
f217759 to
493a046
Compare
|
Ok, updated. thanks @mcbattirola |
ryanclark
approved these changes
Jan 16, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
Backport #51103 to branch/v16
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
This PR makes an update to our logic to the "backdoor" that would keep things hidden after making updates to show most of the features to promote discoverability. Currently, we only continued to hide them if their license specified it, but this incorrectly ignored dashboard, usage based, and team tenants as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes an update to our logic to the "backdoor" that would keep things hidden after making updates to show most of the features to promote discoverability. Currently, we only continued to hide them if their license specified it, but this incorrectly ignored dashboard, usage based, and team tenants as well.