Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] Reissue kube certs when assuming access request #51055

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Jan 15, 2025

Backport #50553 to branch/v17

changelog: Assuming an Access Request in Teleport Connect now propagates elevated permissions to already opened Kubernetes tabs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog: Assuming an access request in Teleport Connect now refreshes open Kubernetes sessions

I think this might not be clear enough to end users who don't know how Connect works behind the scenes. "Kubernetes session" sounds like it might mean kubectl exec --stdin --tty foo -- /bin/bash and then one might wonder what it means for it to be refreshed.

We screwed up a bit by not using the term "local proxy" or at least "gateway" in the UI right from the start – we have no good terminology to refer to what a local proxy is.

How about something like this?

changelog: Assuming an access request in Teleport Connect now propagates elevated permissions to already opened Kubernetes tabs

I looked at the original issue to better understand what kind of language might be more understandable for end users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from tigrato January 15, 2025 11:25
@gzdunek gzdunek added this pull request to the merge queue Jan 15, 2025
Merged via the queue into branch/v17 with commit 8d0cff9 Jan 15, 2025
39 checks passed
@gzdunek gzdunek deleted the bot/backport-50553-branch/v17 branch January 15, 2025 13:01
@camscale camscale mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants