Serve metrics from the local registry in the diagnostic service #51031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
reviewed
Jan 14, 2025
espadolini
approved these changes
Jan 15, 2025
Done in 66970e8
Yup, that's what the metrics service test was doing, I mostly copied it and made it query the diagnostic service instead. The code is a bit duplicated but I don't think the deduplicating this test code is worth the time and complexity. |
rosstimothy
approved these changes
Jan 15, 2025
hugoShaka
added a commit
that referenced
this pull request
Jan 17, 2025
* Use local metrics registry in the diagnostic service * Test metrics are served by the diag service
hugoShaka
added a commit
that referenced
this pull request
Jan 17, 2025
* Use local metrics registry in the diagnostic service * Test metrics are served by the diag service
hugoShaka
added a commit
that referenced
this pull request
Jan 17, 2025
* Use local metrics registry in the diagnostic service * Test metrics are served by the diag service
hugoShaka
added a commit
that referenced
this pull request
Jan 17, 2025
* Use local metrics registry in the diagnostic service * Test metrics are served by the diag service
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
* Use local metrics registry in the diagnostic service * Test metrics are served by the diag service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #50913 I added a local registry and assumed the metrics service was serving the metrics. It appears this is handled by default by the diagnostics service. The metrics service is undocumented (in the config reference) and disabled by default.
This PR: