Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SSH port forwarding options in the role editor #51028

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Jan 14, 2025

Allows both modern and legacy options. Bails out on malformed options and degrades to YAML mode.

Screenshot 2025-01-14 at 17 57 13

This change should bring back support for the built-in editor and auditor roles (v7 only so far).

Allows both modern and legacy options. Bails out on malformed options
and degrades to YAML mode.
@bl-nero bl-nero added the no-changelog Indicates that a PR does not require a changelog entry label Jan 14, 2025
@bl-nero bl-nero requested review from eriktate and avatus January 14, 2025 16:58
@github-actions github-actions bot requested review from kimlisa and rudream January 14, 2025 16:59
Copy link
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERY nice!!! Beautiful even!!

@avatus
Copy link
Contributor

avatus commented Jan 16, 2025

@eriktate please take a look when you get the chance, thank you!

Copy link
Contributor

@eriktate eriktate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for all the effort figuring out the edge cases 🙏

@bl-nero bl-nero added this pull request to the merge queue Jan 16, 2025
Merged via the queue into master with commit 76181c5 Jan 16, 2025
45 checks passed
@bl-nero bl-nero deleted the bl-nero/role-editor-port-forwarding branch January 16, 2025 16:32
@public-teleport-github-review-bot

@bl-nero See the table below for backport results.

Branch Result
branch/v17 Create PR

mvbrock pushed a commit that referenced this pull request Jan 18, 2025
Allows both modern and legacy options. Bails out on malformed options
and degrades to YAML mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants