-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SSH port forwarding options in the role editor #51028
Conversation
Allows both modern and legacy options. Bails out on malformed options and degrades to YAML mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VERY nice!!! Beautiful even!!
@eriktate please take a look when you get the chance, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for all the effort figuring out the edge cases 🙏
Allows both modern and legacy options. Bails out on malformed options and degrades to YAML mode.
Allows both modern and legacy options. Bails out on malformed options and degrades to YAML mode.
This change should bring back support for the built-in editor and auditor roles (v7 only so far).