Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client tools auto-update documentation #50835

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

vapopov
Copy link
Contributor

@vapopov vapopov commented Jan 7, 2025

In this PR added client tools auto-update documentation

Related: https://github.com/gravitational/cloud/issues/10053

@vapopov vapopov added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 backport/branch/v17 labels Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
vapopov/client-tools-autoupdate-docs b3acc1a 13 ✅SUCCEED vapopov-client-tools-autoupdate-docs 2025-01-14 19:09:16

@vapopov vapopov marked this pull request as ready for review January 7, 2025 19:14

This documentation explains how to keep Teleport client tools like `tsh` and `tctl` up-to-date.
Updates can be automatic or self-managed, ensuring tools are secure, free from bugs,
and compatible with your Teleport cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this feature and it's very nice.

Can we add a note / section that outlines which version support this. e.g. if it's shipped with v15, v16, and v17. What's version I need to upgrade to get this feature.

Copy link
Contributor

@benarent benarent Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was back-ported to Teleport 15.4.24, I can't easily tell which other version it's in.

Answer:
17.0.1
16.4.10
15.4.24

Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few initial comments. I haven't read the entire PR yet.

docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved

### How It Works

When you run `tsh login`, the tool will check if updates are enabled for your cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "the tool" refer to here? Is there an update tool that is separate from the client tools it keeps up to date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tool is a general term for tsh, tctl in this context, or potentially even tbot in the future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We should specify this in this paragraph. Otherwise, it is not possible for a reader to infer this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed to the tsh tool, in scope of this example exactly tsh responsible for update

docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
Code review changes
Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While most sidebar sections are autogenerated, the Upgrading section is not. We'll need to update the sidebar configuration by adding an entry here:

{
"title": "Upgrading",
"slug": "/upgrading/upgrading/",
"entries": [
{
"title": "Compatibility Overview",
"slug": "/upgrading/overview/"
},
{
"title": "Set up Automatic Agent Updates",
"slug": "/upgrading/automatic-agent-updates/"
},
{
"title": "Upgrading Reference",
"slug": "/upgrading/upgrading-reference/"
}
]
},

3. Validate the binary with a checksum.
4. Re-execute using the updated version (with the same environment variables).

#### Key features:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to turn the Key features discussion into a couple of paragraphs? Right now, it looks a little jumbled, making it difficult to read:

image

docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
@vapopov vapopov force-pushed the vapopov/client-tools-autoupdate-docs branch from 523d319 to cd98458 Compare January 13, 2025 23:12
@vapopov vapopov force-pushed the vapopov/client-tools-autoupdate-docs branch from cd98458 to 46ae04e Compare January 14, 2025 16:53
docs/config.json Outdated Show resolved Hide resolved
docs/pages/upgrading/client-tools-autoupdate.mdx Outdated Show resolved Hide resolved
Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
Copy link
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@vapopov vapopov added this pull request to the merge queue Jan 15, 2025
Merged via the queue into master with commit f6ca515 Jan 15, 2025
42 checks passed
@vapopov vapopov deleted the vapopov/client-tools-autoupdate-docs branch January 15, 2025 19:51
@public-teleport-github-review-bot

@vapopov See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed
branch/v17 Failed

vapopov added a commit that referenced this pull request Jan 15, 2025
* Add client tools auto-update docs

* Add reference to index page

* Fix linter prose style

* Add section with tctl commands
Code review changes

* Reorganize sections
Add documentation to navigation config
Code review changes

* Add `autoupdate` from command to cspell

* Fix linter warning with relative link

* Update docs/config.json

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>

* Update docs/pages/upgrading/client-tools-autoupdate.mdx

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>

---------

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
vapopov added a commit that referenced this pull request Jan 15, 2025
* Add client tools auto-update docs

* Add reference to index page

* Fix linter prose style

* Add section with tctl commands
Code review changes

* Reorganize sections
Add documentation to navigation config
Code review changes

* Add `autoupdate` from command to cspell

* Fix linter warning with relative link

* Update docs/config.json

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>

* Update docs/pages/upgrading/client-tools-autoupdate.mdx

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>

---------

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
vapopov added a commit that referenced this pull request Jan 15, 2025
* Add client tools auto-update docs

* Add reference to index page

* Fix linter prose style

* Add section with tctl commands
Code review changes

* Reorganize sections
Add documentation to navigation config
Code review changes

* Add `autoupdate` from command to cspell

* Fix linter warning with relative link

* Update docs/config.json

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>

* Update docs/pages/upgrading/client-tools-autoupdate.mdx

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>

---------

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
github-merge-queue bot pushed a commit that referenced this pull request Jan 16, 2025
* Add client tools auto-update docs

* Add reference to index page

* Fix linter prose style

* Add section with tctl commands
Code review changes

* Reorganize sections
Add documentation to navigation config
Code review changes

* Add `autoupdate` from command to cspell

* Fix linter warning with relative link

* Update docs/config.json



* Update docs/pages/upgrading/client-tools-autoupdate.mdx



---------

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
mvbrock pushed a commit that referenced this pull request Jan 18, 2025
* Add client tools auto-update docs

* Add reference to index page

* Fix linter prose style

* Add section with tctl commands
Code review changes

* Reorganize sections
Add documentation to navigation config
Code review changes

* Add `autoupdate` from command to cspell

* Fix linter warning with relative link

* Update docs/config.json

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>

* Update docs/pages/upgrading/client-tools-autoupdate.mdx

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>

---------

Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants