[docs] GitHub proxy admin guide and tsh reference #50772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amplify deployment status
|
ee2aee1 to
c99033f
Compare
f2b8d92 to
3f799da
Compare
ptgott
approved these changes
Jan 7, 2025
docs/pages/admin-guides/management/guides/github-integration.mdx
Outdated
Show resolved
Hide resolved
docs/pages/admin-guides/management/guides/github-integration.mdx
Outdated
Show resolved
Hide resolved
docs/pages/admin-guides/management/guides/github-integration.mdx
Outdated
Show resolved
Hide resolved
docs/pages/admin-guides/management/guides/github-integration.mdx
Outdated
Show resolved
Hide resolved
docs/pages/admin-guides/management/guides/github-integration.mdx
Outdated
Show resolved
Hide resolved
ravicious
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
I allowed myself to run the images through ImageOptim to reduce their size. I also added @2x suffix to github-new-ca.png so that the docs render it as a high DPI screenshot.
|
Well, changing the suffix didn't have any effect, as it seems that the new docs engine doesn't do anything with the prefix (cc @ptgott). Still, it's probably a good idea to have it anyway in case we decide to address high DPI screenshots. |
|
@ptgott the Lint (Docs) is complaining:
It's a file that i have removed in this change. Any idea to fix it? |
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
* [docs] GitHub proxy admin guide and tsh reference * update diagram * update enterprise pre-req * review comment * Run images through ImageOptim, add 2x suffix to github-new-ca * update title --------- Co-authored-by: Rafał Cieślak <rafal.cieslak@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related:
note that the guide for the old method is removed: