Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RequestIdentityMode to PDP requests #50482

Closed
wants to merge 2 commits into from

Conversation

codingllama
Copy link
Contributor

Add RequestIdentityMode to PDP requests, allowing callers to more easily query about 3rd parties or themselves.

Without this feature callers would have to always form a complete request identity, which is
(error-prone) busywork when querying about self and needless complexity when querying about 3rd parties (whose identities those tools shouldn't need to or even be able to form).

Querying about 3rd parties is subject to authz controls, naturally.

#49837

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Dec 20, 2024
@codingllama
Copy link
Contributor Author

Thanks for the reviews. @fspmarshall has an alternative design in mind, so I'll hold this until his has a chance to be reviewed.

@codingllama
Copy link
Contributor Author

Thanks for the reviews. @fspmarshall has an alternative design in mind, so I'll hold this until his has a chance to be reviewed.

Friendly ping @fspmarshall.

@codingllama
Copy link
Contributor Author

Closing as it's likely we'll either go with #50559 or some other in-between approach we talked about out-of-band.

@codingllama codingllama closed this Jan 9, 2025
@codingllama codingllama deleted the codingllama/pdp-identity-target branch January 9, 2025 16:28
@fspmarshall fspmarshall mentioned this pull request Jan 14, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants