Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Azure sync functionality which can be used by the Azure Fetcher #50367

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Adding Azure sync functionality which can be used by the Azure Fetcher #50367

wants to merge 34 commits into from

Conversation

mvbrock
Copy link
Contributor

@mvbrock mvbrock commented Dec 17, 2024 •
edited
Loading

This PR is a result of splitting #48843 into smaller PRs, and a continuation of #50366. It provides the Azure sync functionality which will be called by the Azure fetcher in the Discovery service. It blocks the subsequent PR #50369 to invoke the Azure fetcher as part of the Discovery service.

@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from a590a2b to 9a73b76 Compare December 17, 2024 23:29
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure branch from a817501 to e88e148 Compare December 17, 2024 23:43
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 9a73b76 to 0d11394 Compare December 17, 2024 23:44
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure branch from e88e148 to 308bc2c Compare December 18, 2024 20:29
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from 0d11394 to f4c8928 Compare December 18, 2024 20:31
@mvbrock mvbrock mentioned this pull request Dec 18, 2024
Closed
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch 2 times, most recently from 0f0adcc to 8ef72c4 Compare December 19, 2024 23:50
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure branch 2 times, most recently from 0a4c1f4 to 672ae8d Compare December 20, 2024 00:01
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch 2 times, most recently from 873db7c to b2512a9 Compare December 20, 2024 02:54
@mvbrock mvbrock marked this pull request as ready for review December 20, 2024 03:49
@mvbrock mvbrock marked this pull request as draft December 20, 2024 03:51
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch 2 times, most recently from 1d807fb to 02e6652 Compare December 20, 2024 22:29
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure branch from 2894408 to 0dc6820 Compare December 30, 2024 17:16
@github-actions github-actions bot requested review from avatus and eriktate January 13, 2025 21:12
@mvbrock mvbrock force-pushed the mvbrock/azure-integration-disco-azure-sync branch from f77fd2d to f31b342 Compare January 13, 2025 21:12
@mvbrock mvbrock added the no-changelog Indicates that a PR does not require a changelog entry label Jan 13, 2025
marcoandredinis
marcoandredinis reviewed Jan 15, 2025
View reviewed changes
lib/srv/discovery/common/reconcile.go Outdated Show resolved Hide resolved
lib/srv/discovery/fetchers/azure-sync/azure-sync.go Outdated Show resolved Hide resolved
lib/srv/discovery/fetchers/azure-sync/azure-sync.go Outdated Show resolved Hide resolved
lib/srv/discovery/fetchers/azure-sync/azure-sync.go Outdated Show resolved Hide resolved
lib/srv/discovery/fetchers/azure-sync/azure-sync.go Outdated Show resolved Hide resolved
lib/srv/discovery/fetchers/azure-sync/azure-sync.go Outdated Show resolved Hide resolved
lib/srv/discovery/fetchers/azure-sync/azure-sync_test.go Outdated Show resolved Hide resolved
tigrato
tigrato reviewed Jan 16, 2025
View reviewed changes
lib/utils/slice.go Outdated Show resolved Hide resolved
lib/srv/discovery/fetchers/azure-sync/azure-sync.go Show resolved Hide resolved
lib/srv/discovery/fetchers/azure-sync/azure-sync.go Outdated Show resolved Hide resolved
@mvbrock mvbrock requested review from smallinsky and tigrato January 16, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avatus avatus Awaiting requested review from avatus

@eriktate eriktate Awaiting requested review from eriktate

@marcoandredinis marcoandredinis Awaiting requested review from marcoandredinis

@smallinsky smallinsky Awaiting requested review from smallinsky

@tigrato tigrato Awaiting requested review from tigrato

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
discovery no-changelog Indicates that a PR does not require a changelog entry size/lg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvbrock @marcoandredinis @tigrato @smallinsky