Change autoupdate proto messages #50234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclevine
approved these changes
Dec 13, 2024
vapopov
approved these changes
Dec 13, 2024
zmb3
approved these changes
Dec 13, 2024
codingllama
reviewed
Dec 13, 2024
| // name of the group | ||
| string name = 1; | ||
| // days when the update can run. Supported values are "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun" and "*" | ||
| repeated string days = 2; | ||
| // start_hour to initiate update | ||
| int32 start_hour = 3; | ||
| // wait_days after last group succeeds before this group can run. This can only be used when the strategy is "halt-on-failure". | ||
| int64 wait_days = 4; | ||
| // wait_hours after last group succeeds before this group can run. This can only be used when the strategy is "halt-on-failure". |
There was a problem hiding this comment.
Are zero or negative hours accepted? Is that worth mentioning?
Have you considered google.protobuf.Duration wait_duration?
There was a problem hiding this comment.
Are zero or negative hours accepted? Is that worth mentioning?
No, I'll reject them during validation. Yes I'll add it.
Have you considered google.protobuf.Duration wait_duration?
Yes but we do have a max resolution of an hour with start_hour so it makes more sense to keep the same unit.
codingllama
reviewed
Dec 13, 2024
| @@ -71,14 +71,17 @@ message AgentAutoUpdateSchedules { | |||
|
|
|||
| // AgentAutoUpdateGroup specifies the update schedule for a group of agents. | |||
| message AgentAutoUpdateGroup { | |||
| reserved 4; | |||
| reserved "wait_days"; | |||
There was a problem hiding this comment.
+1 for the clarity of changing from days to an unambiguous time unit. Nicely done.
codingllama
approved these changes
Dec 13, 2024
93c63d8 to
1306783
Compare
This commits does 3 changes: - reflect the maintenance duration on the rollout in a new spec field - add a rollout start time field in its status - change wait_days into wait_hours
1306783 to
3a3dd61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits does 3 changes:
Part of: #47126
Goal (internal): https://github.com/gravitational/cloud/issues/10289
Context: