Forbid custom namespaces in various resources #49830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fspmarshall let me know if you think I missed something. |
fspmarshall
approved these changes
Dec 5, 2024
3f1e72a to
1c3062b
Compare
|
PTAL @fspmarshall. |
rosstimothy
approved these changes
Dec 5, 2024
|
Thanks for the quick reviews, folks. |
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
* Forbid Database and App updates with custom namespaces * Forbid custom namespaces on api/types.KeepAlive * Forbid custom namespaces in api/types.Metadata * Forbid custom namespaces in api/types.RoleV6 * Use a share validation helper, improve error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbid the use of custom namespaces in various resources, akin to commit ae99259. Only "" or "default" (as in apidefaults.Namespace) are allowed.
Namespaces are a vestigial feature from olden Teleport times. It's largely deprecated/unused, but this PR gives us some extra confidence to eventually do a wider cleanup in the future.
(Note: this is not about k8s namespaces.)
#49509