Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that executes tsh with no env vars #49255

Merged
merged 4 commits into from
Nov 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions tool/tsh/common/tsh_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,36 @@ func TestAlias(t *testing.T) {
}
}

// TestNoEnvVars checks if tsh is able to work without any env vars provided.
// This is important for VNet on macOS. When launchd starts VNet's launch daemon, it executes "tsh
// vnet-daemon" with only the following env vars available:
//
// XPC_SERVICE_NAME=com.goteleport.tshdev.vnetd
// PATH=/usr/bin:/bin:/usr/sbin:/sbin
// XPC_FLAGS=1
//
// …plus whatever is set in the launch daemon plist under the EnvironmentVariables key.
func TestNoEnvVars(t *testing.T) {
t.Parallel()
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
t.Cleanup(cancel)

testExecutable, err := os.Executable()
require.NoError(t, err)
// Execute an actual command and not just `tsh help` which goes through a different code path.
cmd := exec.CommandContext(ctx, testExecutable, "version", "--client")
// Run the command with no env vars except tshBinMainTestEnv, otherwise the test would hang.
cmd.Env = []string{fmt.Sprintf("%s=1", tshBinMainTestEnv)}

t.Logf("running command %v", cmd)
output, err := cmd.CombinedOutput()
t.Logf("executable output: %v", string(output))
// By checking the ctx error together with err, the error report will include "context deadline
// exceeded" if the command doesn't complete within the timeout. Otherwise the error would be just
// "signal: killed".
require.NoError(t, trace.NewAggregate(err, ctx.Err()))
}

func TestFailedLogin(t *testing.T) {
t.Parallel()
tmpHomePath := t.TempDir()
Expand Down
Loading