[teleport-update] Add Makefile build target #48531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclevine
approved these changes
Nov 6, 2024
rosstimothy
reviewed
Nov 6, 2024
Makefile
Outdated
| @@ -395,6 +395,10 @@ $(BUILDDIR)/tbot: BUILDFLAGS_TBOT += $(if $(TBOT_CGO_FLAGS), -buildmode=pie) | |||
| $(BUILDDIR)/tbot: | |||
| GOOS=$(OS) GOARCH=$(ARCH) $(TBOT_CGO_FLAGS) go build -tags "$(FIPS_TAG) $(KUSTOMIZE_NO_DYNAMIC_PLUGIN)" -o $(BUILDDIR)/tbot $(BUILDFLAGS_TBOT) ./tool/tbot | |||
|
|
|||
| .PHONY: $(BUILDDIR)/teleport-update | |||
| $(BUILDDIR)/teleport-update: | |||
| GOOS=$(OS) GOARCH=$(ARCH) $(CGOFLAG) go build -o $(BUILDDIR)/teleport-update $(BUILDFLAGS) ./tool/teleport-update | |||
There was a problem hiding this comment.
Does this binary require CGO? If not, should we enforce that by always setting CGO_ENABLED=0 here?
rosstimothy
approved these changes
Nov 6, 2024
vapopov
added a commit
that referenced
this pull request
Feb 20, 2025
* Add build target for teleport-update * Set CGO_ENABLED=0 for building teleport-update
hugoShaka
pushed a commit
that referenced
this pull request
Feb 26, 2025
* Add build target for teleport-update * Set CGO_ENABLED=0 for building teleport-update
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
) * [teleport-update] Add Makefile build target (#48531) * Add build target for teleport-update * Set CGO_ENABLED=0 for building teleport-update * [teleport-update] Add teleport-update to build and archive (#48839) * Add teleport-update to build and archive * Add teleport-update to install scripts * Add build flags without buildmode pie * Add helper message for install.sh script * Exclude teleport-update from darwin platform * Add teleport-update to rpm and deb packages * Remove teleport-update from deb, rpm packages Add comment for the buildflags * [teleport-update] Move teleport binaries to new path {deb,rpm} (#49110) * Move teleport binaries to new path * Use link/unlink command to manage links Move teleport.service to new path * Move teleport binaries under standard path for distroless Cleanup * Fix wrong move path * Create missing directory * Rename link/unlink commands * Exclude teleport-update from docker image Systemd reload now managed by teleport-update Make safe unlink not to block package removal * Add teleport-update to AMI image build * Fix RPM build, fpm automatically manage scripts * Fix AMI build, add missing teleport.service * Move binaries to /opt/teleport/system * Add check to installation script when we copy files from tarball (#50368)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR added build target for teleport-update binary