-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure integration command #47541
Merged
Merged
Azure integration command #47541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvbrock
changed the title
Command to create the managed identity and role for Azure Access Graph sync
Azure integration commands
Dec 23, 2024
mvbrock
force-pushed
the
mvbrock/azure-integration-cmd
branch
from
December 23, 2024 17:23
979537d
to
142264d
Compare
mvbrock
force-pushed
the
mvbrock/azure-integration-cmd
branch
2 times, most recently
from
January 4, 2025 04:10
f25b55b
to
1d508cb
Compare
mvbrock
added
the
no-changelog
Indicates that a PR does not require a changelog entry
label
Jan 5, 2025
rosstimothy
reviewed
Jan 6, 2025
mvbrock
force-pushed
the
mvbrock/azure-integration-cmd
branch
from
January 9, 2025 02:34
bb01fc5
to
452a1c4
Compare
marcoandredinis
approved these changes
Jan 9, 2025
tigrato
approved these changes
Jan 10, 2025
public-teleport-github-review-bot
bot
removed the request for review
from fheinecke
January 10, 2025 15:16
rosstimothy
reviewed
Jan 10, 2025
rosstimothy
approved these changes
Jan 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 16, 2025
mvbrock
added a commit
that referenced
this pull request
Jan 18, 2025
* Initial command to create the managed identity and role * Adding permissions and applying command params * Adding graph permissions to the MSI * Updating parameters * Adding some details and cleaning up comments * Fixing go.sum * Linting * License * PR feedback * Decoupling sync config with an interface for testing * Tweaks to test mocking * PR feedback * Rebase adjustments * PR feedback * Switch to empty struct maps instead of bool maps for set representation * Godocs * Adding user agent to Azure SDK requests * Linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/gravitational/access-graph/issues/1326, this PR provides a new command to assign the necessary Azure and Graph API roles to the managed identity running the Discovery service.