Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide delete button for SSO MFA devices in account settings #47451

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Hide delete button for SSO MFA devices in account settings #47451

merged 1 commit into from
Oct 11, 2024

Conversation

avatus
Copy link
Contributor

@avatus avatus commented Oct 10, 2024

An SSO device cannot be deleted and will fail if you try to delete. This will hide the button to prevent any confusion

@Joerger I'll leave any backporting for this up to you in your larger group of work. LMK

@avatus avatus added the no-changelog Indicates that a PR does not require a changelog entry label Oct 10, 2024
@avatus avatus requested review from bl-nero and Joerger October 10, 2024 16:45
@avatus avatus removed the request for review from ravicious October 10, 2024 16:46
@Joerger Joerger mentioned this pull request Oct 10, 2024
Merged
Joerger
Joerger approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Joerger Joerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with #46704, works great

flyinghermit
flyinghermit approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@flyinghermit flyinghermit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

web/packages/teleport/src/services/mfa/makeMfaDevice.ts Outdated Show resolved Hide resolved
web/packages/teleport/src/services/mfa/makeMfaDevice.ts Show resolved Hide resolved
web/packages/teleport/src/services/mfa/makeMfaDevice.ts Show resolved Hide resolved
web/packages/teleport/src/Account/ManageDevices/AuthDeviceList/AuthDeviceList.tsx Outdated Show resolved Hide resolved
@avatus
Hide delete button for SSO MFA devices in account settings
853972d 
An SSO device cannot be deleted and will fail if you try to delete. This
will hide the button to prevent any confusion
@avatus avatus force-pushed the avatus/sso_no_delete branch from 37de5ab to 853972d Compare October 11, 2024 19:19
@avatus avatus enabled auto-merge October 11, 2024 19:19
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from bl-nero October 11, 2024 19:47
@avatus avatus added this pull request to the merge queue Oct 11, 2024
Merged via the queue into master with commit 6a93736 Oct 11, 2024
39 checks passed
@avatus avatus deleted the avatus/sso_no_delete branch October 11, 2024 19:59
mvbrock pushed a commit that referenced this pull request Oct 16, 2024
@avatus @mvbrock
Hide delete button for SSO MFA devices in account settings (#47451)
c116483 
An SSO device cannot be deleted and will fail if you try to delete. This
will hide the button to prevent any confusion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlisa kimlisa kimlisa approved these changes

@Joerger Joerger Joerger approved these changes

@flyinghermit flyinghermit flyinghermit approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avatus @flyinghermit @Joerger @kimlisa