Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pnpm to 9.8.0 #45722

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Update pnpm to 9.8.0 #45722

merged 2 commits into from
Aug 23, 2024

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Aug 23, 2024

"msw": {
"workerDirectory": [
"web/.storybook/public"
]
}
},
"packageManager": "pnpm@9.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of setting update-notifier to false, as the pnpm team releases new versions pretty often and we don't need to stay at the freshest version at all times.

Too bad that dependabot cannot update pnpm for us, otherwise with update-notifier turned off we'd have to remember about the updates ourselves.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think disabling the notifications makes sense, 9.8.0 is the third release in August only. It's a bit annoying to see this notification that often.
Hopefully one day Dependeabot will support updating packageManager.

@gzdunek gzdunek added this pull request to the merge queue Aug 23, 2024
Merged via the queue into master with commit 254292b Aug 23, 2024
41 of 42 checks passed
@gzdunek gzdunek deleted the gzdunek/pnpm-9.8.0 branch August 23, 2024 15:03
@public-teleport-github-review-bot

@gzdunek See the table below for backport results.

Branch Result
branch/v16 Failed

gzdunek added a commit that referenced this pull request Aug 23, 2024
* Update pnpm to 9.8.0

* Set `update-notifier=false`

(cherry picked from commit 254292b)
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2024
* Update pnpm to 9.8.0

* Set `update-notifier=false`

(cherry picked from commit 254292b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants