[v16] fix: drop reserved source key in slog.Logger
#43389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `source` key in slog.Logger is a reserved key and should not be used because it causes a panic. This commit removes the `source` key from the logger. Note: We already enforce the forbidden keys as per #42049. However, our lint jobs currently only run on Ubuntu runners, while the code in question compiles for Darwin targets only. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
espadolini
approved these changes
Jun 22, 2024
avatus
approved these changes
Jun 22, 2024
rosstimothy
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #43388 to branch/v16