Close expired gRPC connections if disconnect_expired_cert is set #41826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the transport credentials used by gRPC servers that require mTLS to enforce that connections are terminated when the client certificate expires if `disconnect_expired_cert == true`. To prevent session resumption from leaving open sessions established through the Proxy gRPC server the redial mechanism was updated to inspect for certificate expired errors and abort any future reconnection attempts. Partially addresses #1199.
0c4e8d1 to
4d31539
Compare
r0mant
approved these changes
May 21, 2024
zmb3
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the transport credentials used by gRPC servers that require mTLS to enforce that connections are terminated when the client certificate expires if
disconnect_expired_cert == true. To prevent session resumption from leaving open sessions established through the Proxy gRPC server the redial mechanism was updated to inspect for certificate expired errors and abort any future reconnection attempts.Changelog: Terminate gRPC connections when client certificates are expired if the cluster has enabled
disconnect_expired_cert.